Surface admin-disabled remote plugin status#20298
Conversation
af02002 to
90cbfda
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
| /// Remote-only availability status. Local plugins leave this unset. | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| #[ts(optional)] | ||
| pub status: Option<PluginAvailabilityStatus>, |
There was a problem hiding this comment.
Let’s call it “availability” / “visibility” instead — “status” feels too generic.
| #[derive(Serialize, Deserialize, Debug, Clone, Copy, PartialEq, Eq, JsonSchema, TS)] | ||
| #[ts(export_to = "v2/")] | ||
| pub enum PluginAvailabilityStatus { | ||
| #[serde(rename = "AVAILABLE", alias = "ENABLED")] |
There was a problem hiding this comment.
Why do you have an alias here?
There was a problem hiding this comment.
this enun server 2 sides, this is the tranlsation of the GPT API and the one we sent to desktop
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Remote plugin-service returns plugin availability separately from a user's installed/enabled state. This adds
PluginAvailabilityStatusto the app-server protocol, propagates remote catalogstatusintoPluginSummary, and rejects install attempts for remote plugins markedDISABLED_BY_ADMINbefore downloading or caching the bundle.This is the
openai/codexhalf of the change. The companionopenai/openaiwebview PR is https://github.com/openai/openai/pull/873269.Validation
cargo run -p codex-app-server-protocol --bin write_schema_fixturescargo test -p codex-app-server --test all plugin_list_marks_remote_plugin_disabled_by_admincargo test -p codex-app-server --test all plugin_list_includes_remote_marketplaces_when_remote_plugin_enabledcargo test -p codex-app-server --test all plugin_install_rejects_remote_plugin_disabled_by_admin_before_downloadcargo test -p codex-app-server-protocol schema_fixtures