Refresh remote plugin cache on auth changes by xli-oai · Pull Request #20265 · openai/codex

xli-oai · 2026-04-29T21:38:08Z

Summary

Refresh the remote installed-plugin cache after login/logout instead of keying it by account or eagerly clearing it.
Reuse the existing single-flight remote installed refresh loop so newer queued auth refreshes replace older pending requests and the API result eventually overwrites or clears the cache.
Keep derived plugin/skills cache and MCP refresh side effects behind the existing effective-plugin-changed task when the refreshed installed state changes.
Leave clear_plugin_related_caches scoped to derived plugin/skills caches so share mutations do not drop remote installed plugins.

Tests

cargo fmt --all --manifest-path codex-rs/Cargo.toml (passes; stable rustfmt warns that imports_granularity = Item is nightly-only)
cargo test -p codex-core-plugins remote_installed_cache
cargo test -p codex-app-server skills_list_loads_remote_installed_plugin_skills_from_cache

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/core/src/connectors.rs

Line 411 in b2f8365

.plugins_for_config(config)

Pass auth when computing tool-suggest connector IDs

tool_suggest_connector_ids now calls plugins_for_config(config) without auth. After this commit, remote-installed plugin configs are returned only when the account-scoped cache key is present, so this path drops remote plugin connector IDs. list_tool_suggest_discoverable_tools_with_auth then filters them out, so connectors from remote-installed plugins stop appearing in tool suggestions.

codex/codex-rs/core/src/mcp.rs

Line 24 in b2f8365

let mcp_config = config.to_mcp_config(self.plugins_manager.as_ref()).await;

Thread auth into configured MCP server resolution

configured_servers still builds MCP config via to_mcp_config(...) (no auth). With the new account-keyed remote plugin cache, that omits remote-installed plugin MCP servers entirely. Callers like app-server MCP refresh/OAuth flows using configured_servers can no longer find remote plugin servers, causing refreshes to drop them or OAuth login to fail with “No MCP server named ...”.

codex/codex-rs/chatgpt/src/connectors.rs

Line 140 in b2f8365

.plugins_for_config(config)

Pass auth when merging plugin apps into connector list

list_all_connectors_with_options fetches authenticated connector data, but plugin_apps_for_config still calls plugins_for_config(config) without auth. After account-keyed remote plugin caching, remote-installed plugin apps are omitted here, so plugin-provided connectors disappear from the merged connector list for logged-in users.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

xli-oai · 2026-04-30T23:38:35Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f79953f8d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

xli-oai · 2026-05-01T00:52:44Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11ba7ac58d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

xli-oai · 2026-05-01T01:30:35Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed5cad747e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b9e433d903

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

xli-oai · 2026-05-01T03:42:09Z

@codex review

chatgpt-codex-connector · 2026-05-01T03:46:54Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

xli-oai · 2026-05-01T05:05:25Z

                &outgoing_clone,
-                auth_manager,
                config_manager,
+                thread_manager,


send_chatgpt_login_completion_notifications take too many params and will break CI, so replace auth_manager with thread_manager instead of creating a new xxxContext :)

xli-oai requested a review from a team as a code owner April 29, 2026 21:38

xli-oai added the oai PRs contributed by OpenAI employees label Apr 29, 2026 — with ChatGPT Codex Connector

chatgpt-codex-connector Bot reviewed Apr 29, 2026

View reviewed changes

xli-oai force-pushed the xli-codex/remote-plugin-cache-key branch from b2f8365 to a32caff Compare April 30, 2026 01:16

This was referenced Apr 30, 2026

📊 AI CLI 工具社区动态日报 2026-04-30 gsscsd/big_model_radar#269

Open

📊 AI CLI 工具社区动态日报 2026-04-30 borq168/radar-forge#79

Open

xli-oai force-pushed the xli-codex/remote-plugin-cache-key branch 2 times, most recently from 2b78046 to 6cd565e Compare April 30, 2026 06:53

iamhectorlopez mentioned this pull request Apr 30, 2026

Feature request: support multiple named accounts per app/connector #20500

Open

xli-oai force-pushed the xli-codex/remote-plugin-cache-key branch 2 times, most recently from f54f204 to 5f79953 Compare April 30, 2026 23:25

xli-oai force-pushed the xli-codex/remote-plugin-cache-key branch 2 times, most recently from c414c0f to 3b6c42c Compare April 30, 2026 23:48

chatgpt-codex-connector Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread codex-rs/app-server/src/codex_message_processor.rs Outdated

Comment thread codex-rs/core-plugins/src/manager.rs Outdated

Comment thread codex-rs/core-plugins/src/manager.rs

Comment thread codex-rs/core-plugins/src/manager.rs Outdated

xli-oai force-pushed the xli-codex/remote-plugin-cache-key branch 7 times, most recently from 4edeb33 to 11ba7ac Compare May 1, 2026 00:51

chatgpt-codex-connector Bot reviewed May 1, 2026

View reviewed changes

Comment thread codex-rs/app-server/src/codex_message_processor.rs Outdated

xli-oai force-pushed the xli-codex/remote-plugin-cache-key branch from 11ba7ac to ed5cad7 Compare May 1, 2026 01:11

chatgpt-codex-connector Bot reviewed May 1, 2026

View reviewed changes

Comment thread codex-rs/app-server/src/codex_message_processor.rs

xl-openai reviewed May 1, 2026

View reviewed changes

Comment thread codex-rs/app-server/src/codex_message_processor.rs

xl-openai reviewed May 1, 2026

View reviewed changes

Comment thread codex-rs/core-plugins/src/manager.rs Outdated

github-actions Bot mentioned this pull request May 1, 2026

📊 AI CLI 工具社区动态日报 2026-05-01 gsscsd/big_model_radar#275

Open

xli-oai force-pushed the xli-codex/remote-plugin-cache-key branch from 6608032 to 61871c9 Compare May 1, 2026 01:58

This was referenced May 1, 2026

📊 AI CLI 工具社区动态日报 2026-05-01 borq168/radar-forge#91

Open

📊 AI CLI Tools Digest 2026-05-01 borq168/radar-forge#94

Open

Key remote plugin cache by account

569aa4d

xli-oai force-pushed the xli-codex/remote-plugin-cache-key branch 2 times, most recently from 7e34315 to ab92d79 Compare May 1, 2026 03:17

xli-oai changed the title ~~Key remote plugin cache by account~~ Refresh remote plugin cache on auth changes May 1, 2026

xli-oai force-pushed the xli-codex/remote-plugin-cache-key branch 8 times, most recently from 0d47d45 to 209f248 Compare May 1, 2026 03:38

chatgpt-codex-connector Bot reviewed May 1, 2026

View reviewed changes

Comment thread codex-rs/app-server/src/codex_message_processor.rs Outdated

xli-oai force-pushed the xli-codex/remote-plugin-cache-key branch from 209f248 to e3e058d Compare May 1, 2026 03:41

xli-oai force-pushed the xli-codex/remote-plugin-cache-key branch 4 times, most recently from 47c79d4 to e3e058d Compare May 1, 2026 04:40

Refresh remote plugin cache on auth changes

3c92d6c

xli-oai force-pushed the xli-codex/remote-plugin-cache-key branch from e3e058d to 3c92d6c Compare May 1, 2026 04:51

xli-oai commented May 1, 2026

View reviewed changes

xl-openai approved these changes May 1, 2026

View reviewed changes

xli-oai merged commit a62b52f into main May 1, 2026
25 checks passed

xli-oai deleted the xli-codex/remote-plugin-cache-key branch May 1, 2026 06:11

github-actions Bot locked and limited conversation to collaborators May 1, 2026

Conversation

xli-oai commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tests

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

xli-oai commented Apr 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xli-oai commented May 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

xli-oai commented May 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

xli-oai commented May 1, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 1, 2026

Uh oh!

xli-oai May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

xli-oai commented Apr 29, 2026 •

edited

Loading