Skip to content

/plugins: remove marketplace#19843

Merged
canvrno-oai merged 4 commits into
mainfrom
canvrno/tui_plugins_menu_v2_marketplace_remove
Apr 30, 2026
Merged

/plugins: remove marketplace#19843
canvrno-oai merged 4 commits into
mainfrom
canvrno/tui_plugins_menu_v2_marketplace_remove

Conversation

@canvrno-oai

@canvrno-oai canvrno-oai commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

This PR adds marketplace removal to the /plugins menu, giving users a way to remove user-configured plugin marketplaces. It adds a Ctrl+R shortcut to remove selected marketplace tabs, a confirmation prompt, loading and error states, and the app-server request flow needed to perform marketplace/remove. After a successful removal, the TUI refreshes config, plugin mentions, user config, and plugin data so the removed marketplace disappears from the menu and other surfaces in the TUI.

  • Add Ctrl+R removal option for user-configured marketplace tabs
  • Show marketplace removal confirmation, loading, and error states
  • Route marketplace/remove through the TUI background request flow
  • Refresh config, plugin mentions, and plugin data after successful removal
  • Adds reusable per-tab footer hints so removal guidance only appears on applicable tabs
  • Add test coverage for Ctrl+R behavior while plugin search is active

Steps to test:

  • Add a marketplace using the TUI /plugins menu
  • Use Ctrl+R to remove the marketplace
  • Accept the confirmation prompt
  • Confirm the marketplace is removed when the process completes.

@canvrno-oai canvrno-oai force-pushed the canvrno/tui_plugins_menu_v2_marketplace_remove branch 3 times, most recently from b6b751a to f51e6bd Compare April 28, 2026 21:29
@canvrno-oai canvrno-oai force-pushed the canvrno/tui_plugins_menu_v2_marketplace_remove branch 2 times, most recently from 672bfc8 to c74761f Compare April 29, 2026 01:48
@canvrno-oai canvrno-oai marked this pull request as ready for review April 29, 2026 02:00
@canvrno-oai

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@canvrno-oai canvrno-oai force-pushed the canvrno/tui_plugins_menu_v2_marketplace_remove branch from c9e77c9 to 2ca712f Compare April 29, 2026 18:05
@canvrno-oai

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0ceb68ff47

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/chatwidget/plugins.rs
Comment thread codex-rs/tui/src/app/event_dispatch.rs
Comment thread codex-rs/tui/src/app/event_dispatch.rs

@fcoury-oai fcoury-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done a basic smoke test of adding a marketplace and removing it and it worked correctly.

Code looks good, approved!

@canvrno-oai canvrno-oai merged commit a85d265 into main Apr 30, 2026
25 checks passed
@canvrno-oai canvrno-oai deleted the canvrno/tui_plugins_menu_v2_marketplace_remove branch April 30, 2026 17:25
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants