Persist shell mode commands in prompt history#19618
Merged
Merged
Conversation
This was referenced Apr 26, 2026
fcoury-oai
approved these changes
Apr 27, 2026
fcoury-oai
left a comment
Contributor
There was a problem hiding this comment.
Tested before and after and codex confirmed no findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
!shell commands are currently surfaced as "Bash mode", which is misleading for users running shells such as PowerShell or zsh. Those commands also bypass the persistent prompt history path, so they cannot be recalled after starting a new session.Fixes #19613.
What changed
!shell commands to prompt history with the leading!, so recall restores the composer into shell mode across sessions.Verification
cargo test -p codex-tui bang_shellcargo test -p codex-tui shell_command_uses_shell_accent_stylecargo test -p codex-tui footer_mode_snapshotscargo insta pending-snapshots --manifest-path tui/Cargo.tomlManually verified fix after confirming presence of bug prior to fix.