Streamline plugin, apps, and skills handlers#19490
Conversation
633d4a6 to
13c6797
Compare
There was a problem hiding this comment.
💡 Codex Review
https://github.com/openai/codex/blob/13c6797da34da5d25a925924679e9333f291fcb9/codex-rs/app-server/src/codex_message_processor.rs#L3115
Restore send_internal_error helper to compile app-server
This commit removes async fn send_internal_error(...) but leaves many calls like self.send_internal_error(...) intact. As a result, codex-app-server no longer type-checks (method not found on CodexMessageProcessor) and the build is blocked. Re-introduce the helper (or replace all remaining callsites) before merging.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
13c6797 to
244a3ff
Compare
244a3ff to
c6c2d92
Compare
c6c2d92 to
a09b616
Compare
Why
The plugin, app, and skills handlers had a lot of repeated
send_error/returnbranches that made the success path hard to scan. This slice keeps behavior the same while moving fallible steps into local response-producing helpers, so the request boundary can send one result.What Changed
codex-rs/app-server/src/codex_message_processor/plugins.rsto returnResult<*Response, JSONRPCErrorError>from helper methods and callsend_resultonce.codex-rs/app-server/src/codex_message_processor.rs.Verification
cargo check -p codex-app-servercargo test -p codex-app-server --test all v2::app_list -- --test-threads=1cargo test -p codex-app-server --test all v2::plugin_ -- --test-threads=1cargo test -p codex-app-server --test all v2::skills_list -- --test-threads=1