Skip to content

[codex] Migrate thread turns list to thread store#19280

Merged
wiltzius-openai merged 1 commit into
mainfrom
wiltzius/codex/thread-turns-list-store-read
Apr 30, 2026
Merged

[codex] Migrate thread turns list to thread store#19280
wiltzius-openai merged 1 commit into
mainfrom
wiltzius/codex/thread-turns-list-store-read

Conversation

@wiltzius-openai

@wiltzius-openai wiltzius-openai commented Apr 24, 2026

Copy link
Copy Markdown
Contributor
  • migrate thread/turns/list to ThreadStore. Uses ThreadStore for most data now but merges in the in-memory state from thread manager
  • keep v2 thread/list pathless-store friendly by converting StoredThread directly to API Thread
  • add regression coverage for pathless store history/listing

@wiltzius-openai wiltzius-openai changed the title wiltzius/codex/thread turns list store read [codex] Migrate thread turns list to thread store Apr 24, 2026
@wiltzius-openai wiltzius-openai marked this pull request as ready for review April 24, 2026 04:25
@wiltzius-openai wiltzius-openai requested a review from a team as a code owner April 24, 2026 04:25
@wiltzius-openai wiltzius-openai changed the base branch from main to wiltzius/codex/thread-store-fork-resume April 24, 2026 04:31
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

💡 Codex Review

let result = if let Some(path) = path {
self.thread_store
.read_thread_by_rollout_path(StoreReadThreadByRolloutPathParams {
rollout_path: path.clone(),
include_archived: true,
include_history,
})
.await

P1 Badge Keep path-based fork/resume working with remote thread stores

thread/resume and thread/fork are documented to accept path, but this helper now routes every path-based request through ThreadStore::read_thread_by_rollout_path(). RemoteThreadStore hard-fails that method, so enabling experimental_thread_store_endpoint turns valid path-based requests into internal errors instead of loading the local rollout as before.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch 2 times, most recently from 079c897 to 9298207 Compare April 24, 2026 18:39
Base automatically changed from wiltzius/codex/thread-store-fork-resume to main April 24, 2026 20:51
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-turns-list-store-read branch from 6addbab to 98077a0 Compare April 24, 2026 21:17
@wiltzius-openai wiltzius-openai changed the base branch from main to wiltzius/codex/non-local-thread-store-regression April 24, 2026 21:17
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-turns-list-store-read branch from 98077a0 to 42ed3b4 Compare April 24, 2026 21:23
Base automatically changed from wiltzius/codex/non-local-thread-store-regression to main April 24, 2026 22:45
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-turns-list-store-read branch 4 times, most recently from eee1d6a to 80405fd Compare April 25, 2026 00:32
Comment thread codex-rs/app-server/src/codex_message_processor.rs Outdated
Comment thread codex-rs/app-server/src/codex_message_processor.rs Outdated
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-turns-list-store-read branch 4 times, most recently from 1529ffe to 429ff74 Compare April 30, 2026 17:41
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-turns-list-store-read branch from 429ff74 to 7a66f25 Compare April 30, 2026 17:51
@wiltzius-openai

Copy link
Copy Markdown
Contributor Author

/merge

@wiltzius-openai wiltzius-openai merged commit 127be06 into main Apr 30, 2026
35 of 36 checks passed
@wiltzius-openai wiltzius-openai deleted the wiltzius/codex/thread-turns-list-store-read branch April 30, 2026 21:16
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants