Conversation
dylan-hurd-oai
approved these changes
Apr 23, 2026
877d0fb to
4ed92c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
item/permissions/requestApprovalsends a requested permission profile to app-server clients. The core profile already stores filesystem permissions asentries, but the v2 compatibility conversion used the legacyread/writeprojection whenever possible and leftentriesunset.That made the request ambiguous for clients that consume the canonical v2 shape:
permissions.fileSystem.entrieswas missing even though filesystem access was being requested. A client that rendered or echoed grants fromentriescould treat the request as having no filesystem permission entries, then return an empty or incomplete grant. The app-server intersects responses with the original request, so omitted filesystem permissions are denied.What Changed
AdditionalFileSystemPermissions.entrieswhen converting legacy read/write roots for request permission payloads, while preservingreadandwritefor compatibility.readandwriteas transitional schema fields in the generated app-server schema.item/permissions/requestApprovalround trip, and TUI app-server approval conversion expectations.Verification
just fmtcargo test -p codex-app-server-protocolcargo test -p codex-app-server request_permissions_round_tripcargo test -p codex-tui converts_request_permissions_into_granted_permissionscargo test -p codex-tui resolves_permissions_and_user_input_through_app_server_request_id