tui: fix approvals popup disabled shortcut test#19072
Merged
Merged
Conversation
dylan-hurd-oai
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This regressed in #19063, which made
GuardianApprovalstable and enabled by default. That adds an enabledAuto-reviewrow to the permissions popup, butapprovals_popup_navigation_skips_disabledstill assumed the disabledFull Accessrow lived behind a hard-coded numeric shortcut, so the test started selecting a different row and closing the popup instead of verifying disabled-row behavior.What
GuardianApprovalinapprovals_popup_navigation_skips_disabledso the popup layout matches the scenario the test is exercisingFull Accessrow by platform (2on non-Windows,3on Windows whereRead Onlyis shown) before asserting that selecting the disabled row leaves the popup openTesting
cargo test -p codex-tui --lib chatwidget::tests::permissions::approvals_popup_navigation_skips_disabled -- --exact --nocapturecargo test -p codex-tui --lib chatwidget::tests::permissions -- --nocapturecargo test -p codex-tui