Skip to content

tui: fix approvals popup disabled shortcut test#19072

Merged
bolinfest merged 1 commit into
mainfrom
codex/fix-approvals-popup-disabled-test
Apr 23, 2026
Merged

tui: fix approvals popup disabled shortcut test#19072
bolinfest merged 1 commit into
mainfrom
codex/fix-approvals-popup-disabled-test

Conversation

@bolinfest

@bolinfest bolinfest commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

Why

This regressed in #19063, which made GuardianApproval stable and enabled by default. That adds an enabled Auto-review row to the permissions popup, but approvals_popup_navigation_skips_disabled still assumed the disabled Full Access row lived behind a hard-coded numeric shortcut, so the test started selecting a different row and closing the popup instead of verifying disabled-row behavior.

What

  • disable GuardianApproval in approvals_popup_navigation_skips_disabled so the popup layout matches the scenario the test is exercising
  • choose the hidden numeric shortcut for the disabled Full Access row by platform (2 on non-Windows, 3 on Windows where Read Only is shown) before asserting that selecting the disabled row leaves the popup open

Testing

  • cargo test -p codex-tui --lib chatwidget::tests::permissions::approvals_popup_navigation_skips_disabled -- --exact --nocapture
  • cargo test -p codex-tui --lib chatwidget::tests::permissions -- --nocapture
  • cargo test -p codex-tui

@bolinfest bolinfest enabled auto-merge (squash) April 23, 2026 03:09
@bolinfest bolinfest disabled auto-merge April 23, 2026 04:01
@bolinfest bolinfest merged commit 9955eac into main Apr 23, 2026
34 of 36 checks passed
@bolinfest bolinfest deleted the codex/fix-approvals-popup-disabled-test branch April 23, 2026 04:01
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants