Overlay state DB git metadata for filtered thread lists#19036
Merged
joeytrasatti-openai merged 2 commits intoApr 22, 2026
Conversation
acrognale-oai
approved these changes
Apr 22, 2026
jif-oai
reviewed
Apr 22, 2026
jif-oai
left a comment
Collaborator
There was a problem hiding this comment.
lgtm. The bad design must be fixed but can be in a follow-up
| page | ||
| } | ||
|
|
||
| fn fill_missing_thread_item_metadata(item: &mut ThreadItem, state_item: ThreadItem) { |
Collaborator
There was a problem hiding this comment.
this looks bad and probably hide a bad design
jif-oai
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThreadMetadatato rolloutThreadItemmapping into a shared helper used by both DB pages and filesystem overlaysThreadItem, while preserving filesystempathandthread_idThreadItemfields require an explicit decisionTesting
just fmtfromcodex-rsgit diff --check -- codex-rs/rollout/src/recorder.rs codex-rs/rollout/src/recorder_tests.rscargo test -p codex-rollout thread_item_metadatafromcodex-rs; blocked in dependency fetch/setup after updating crates.io and git submoduleshttps://github.com/livekit/protocolandhttps://chromium.googlesource.com/libyuv/libyuv, so the focused tests did not run