Skip to content

ci: keep argument comment lint checks materialized#18926

Merged
bolinfest merged 1 commit into
mainfrom
pr18926
Apr 22, 2026
Merged

ci: keep argument comment lint checks materialized#18926
bolinfest merged 1 commit into
mainfrom
pr18926

Conversation

@bolinfest

@bolinfest bolinfest commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Why

The fast rust-ci workflow decides whether to run the cross-platform argument-comment-lint job based on changed paths. PRs that touch Rust-adjacent Bazel wrapper files, such as defs.bzl or workspace_root_test_launcher.*.tpl, can change how Rust tests and lint targets behave without changing any .rs files.

When that detector returned false, GitHub skipped the matrix job before expanding it. That produced a single skipped check named Argument comment lint - ${{ matrix.name }} instead of the Linux, macOS, and Windows check names that branch protection expects, leaving the PR unable to go green when those matrix checks are required.

What Changed

  • Treat root Bazel wrapper files as argument-comment-lint relevant changes.
  • Keep the argument_comment_lint_prebuilt matrix job materialized for every PR so the per-platform check names always exist.
  • Add a single gate step that decides whether the real lint work should run.
  • Move the checkout-adjacent Bazel setup and OS-specific lint commands into .github/actions/run-argument-comment-lint/action.yml so the workflow does not repeat the same path-detection condition on each step.

Verification

  • Parsed .github/workflows/rust-ci.yml and .github/actions/run-argument-comment-lint/action.yml with Python YAML loading.
  • Simulated the workflow path-matching shell conditions for the root Bazel wrapper files and confirmed they set argument_comment_lint=true.

@bolinfest bolinfest enabled auto-merge (squash) April 22, 2026 03:14
@bolinfest bolinfest merged commit 03ae4db into main Apr 22, 2026
48 of 61 checks passed
@bolinfest bolinfest deleted the pr18926 branch April 22, 2026 03:36
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants