Conversation
pakrym-oai
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The fast
rust-ciworkflow decides whether to run the cross-platformargument-comment-lintjob based on changed paths. PRs that touch Rust-adjacent Bazel wrapper files, such asdefs.bzlorworkspace_root_test_launcher.*.tpl, can change how Rust tests and lint targets behave without changing any.rsfiles.When that detector returned false, GitHub skipped the matrix job before expanding it. That produced a single skipped check named
Argument comment lint - ${{ matrix.name }}instead of the Linux, macOS, and Windows check names that branch protection expects, leaving the PR unable to go green when those matrix checks are required.What Changed
argument-comment-lintrelevant changes.argument_comment_lint_prebuiltmatrix job materialized for every PR so the per-platform check names always exist..github/actions/run-argument-comment-lint/action.ymlso the workflow does not repeat the same path-detection condition on each step.Verification
.github/workflows/rust-ci.ymland.github/actions/run-argument-comment-lint/action.ymlwith Python YAML loading.argument_comment_lint=true.