Load app-server config through ConfigManager#18870
Merged
Merged
Conversation
5e84849 to
2945d4b
Compare
starr-openai
approved these changes
Apr 21, 2026
2945d4b to
14320c4
Compare
14320c4 to
1f3c022
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigManagerinstead of directConfigBuildercalls.ConfigManagerconstructor-owned state (cli_overrides, runtime feature map, cloud requirements loader) behind internal manager fields.ConfigManagerintoMessageProcessordirectly instead of reconstructing it from raw args.Tests
cargo check -p codex-app-servercargo test -p codex-app-serverjust fix -p codex-app-serverjust fmt