Skip to content

Support multiple cwd filters for thread list#18502

Merged
acrognale-oai merged 9 commits into
mainfrom
acrognale/thread-list-cwds
Apr 22, 2026
Merged

Support multiple cwd filters for thread list#18502
acrognale-oai merged 9 commits into
mainfrom
acrognale/thread-list-cwds

Conversation

@acrognale-oai

@acrognale-oai acrognale-oai commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Teach app-server thread/list to accept either a single cwd or an array of cwd filters, returning threads whose recorded session cwd matches any requested path
  • Add useStateDbOnly as an explicit opt-in fast path for callers that want to answer thread/list from SQLite without scanning JSONL rollout files
  • Preserve backwards compatibility: by default, thread/list still scans JSONL rollouts and repairs SQLite state
  • Wire the new cwd array and SQLite-only options through app-server, local/remote thread-store, rollout listing, generated TypeScript/schema fixtures, proto output, and docs

Test Plan

  • cargo test -p codex-app-server-protocol
  • cargo test -p codex-rollout
  • cargo test -p codex-thread-store
  • cargo test -p codex-app-server thread_list
  • just fmt
  • just fix -p codex-app-server-protocol -p codex-rollout -p codex-thread-store -p codex-app-server
  • cargo build -p codex-cli --bin codex

@acrognale-oai acrognale-oai marked this pull request as draft April 18, 2026 20:45
@acrognale-oai acrognale-oai requested a review from jif-oai April 19, 2026 21:16
@acrognale-oai acrognale-oai marked this pull request as ready for review April 19, 2026 21:16

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the null seems to be actually lost. This is a breaking change

@acrognale-oai acrognale-oai requested a review from a team as a code owner April 20, 2026 22:46
@acrognale-oai acrognale-oai force-pushed the acrognale/thread-list-cwds branch from 202cff1 to 499d2de Compare April 20, 2026 22:58

@jif-oai jif-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acrognale-oai acrognale-oai force-pushed the acrognale/thread-list-cwds branch 4 times, most recently from 184ffa6 to ffdcf01 Compare April 21, 2026 21:24
@acrognale-oai acrognale-oai force-pushed the acrognale/thread-list-cwds branch from ffdcf01 to fae43d4 Compare April 21, 2026 21:33
@acrognale-oai acrognale-oai merged commit 4f8c58f into main Apr 22, 2026
25 checks passed
@acrognale-oai acrognale-oai deleted the acrognale/thread-list-cwds branch April 22, 2026 10:10
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants