Skip to content

Avoid false shell snapshot cleanup warnings#18441

Merged
jif-oai merged 1 commit into
mainfrom
etraut/snapshot_cleanup
Apr 20, 2026
Merged

Avoid false shell snapshot cleanup warnings#18441
jif-oai merged 1 commit into
mainfrom
etraut/snapshot_cleanup

Conversation

@etraut-openai

@etraut-openai etraut-openai commented Apr 18, 2026

Copy link
Copy Markdown
Collaborator

Why

Fresh app-server thread startup can create a shell snapshot through a temp file and then promote it to the final snapshot path. The previous implementation briefly wrapped the temp path in ShellSnapshot, so after a successful rename its Drop attempted to delete the old temp path and could log a false ENOENT warning.

Fixes #17549.

What changed

  • Validate the temp snapshot path directly before promotion.
  • Rename the temp path directly to the final snapshot path.
  • Keep explicit cleanup of the temp path on validation or finalization failures.

@jif-oai jif-oai merged commit fa0e2ba into main Apr 20, 2026
25 checks passed
@jif-oai jif-oai deleted the etraut/snapshot_cleanup branch April 20, 2026 14:15
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shell snapshot logs false ENOENT on temp cleanup after thread/start

2 participants