Skip to content

app-server: track remote-control seq IDs per stream#17902

Merged
euroelessar merged 1 commit into
mainfrom
ruslan/remote-control-stream-seq-id
Apr 15, 2026
Merged

app-server: track remote-control seq IDs per stream#17902
euroelessar merged 1 commit into
mainfrom
ruslan/remote-control-stream-seq-id

Conversation

@euroelessar

@euroelessar euroelessar commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Track outbound remote-control sequence IDs independently for each client stream.
  • Retain unacked outbound messages per stream using FIFO buffers.
  • Require stream-scoped acks and update tests for contiguous per-stream sequencing.

Why

The remote-control peer uses outbound sequence gaps to detect lost messages and re-initialize. A single global outbound sequence counter can create apparent gaps on an individual stream when another stream receives an interleaved message.

Validation

  • just fmt
  • cargo test -p codex-app-server remote_control
  • just fix -p codex-app-server
  • git diff --check

## Summary

- Track outbound remote-control sequence IDs independently for each client stream.
- Retain unacked outbound messages per stream using FIFO buffers.
- Require stream-scoped acks and update tests for contiguous per-stream sequencing.

## Validation

- just fmt
- cargo test -p codex-app-server remote_control
- just fix -p codex-app-server
- git diff --check
@euroelessar euroelessar force-pushed the ruslan/remote-control-stream-seq-id branch from 6cd9d37 to 4c34365 Compare April 15, 2026 17:15
@euroelessar euroelessar marked this pull request as ready for review April 15, 2026 17:53
@euroelessar euroelessar merged commit 83abf67 into main Apr 15, 2026
43 of 47 checks passed
@euroelessar euroelessar deleted the ruslan/remote-control-stream-seq-id branch April 15, 2026 18:52
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants