Skip to content

Reuse remote exec-server in core tests#17837

Merged
starr-openai merged 2 commits into
mainfrom
starr/remote-full-ci-minimal-20260414
Apr 15, 2026
Merged

Reuse remote exec-server in core tests#17837
starr-openai merged 2 commits into
mainfrom
starr/remote-full-ci-minimal-20260414

Conversation

@starr-openai

@starr-openai starr-openai commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • reuse a shared remote exec-server for remote-aware codex-core integration tests within a test binary process
  • keep per-test remote cwd creation and cleanup so tests retain workspace isolation
  • leave codex_self_exe, codex_linux_sandbox_exe, cwd_path(), and workspace_path() behavior unchanged

Validation

  • rustfmt codex-rs/core/tests/common/test_codex.rs
  • git diff --check
  • CI is running on the updated branch

@starr-openai starr-openai mentioned this pull request Apr 14, 2026
Closed
@starr-openai starr-openai force-pushed the starr/remote-full-ci-minimal-20260414 branch from 5fbfb1f to 2f30428 Compare April 14, 2026 22:29
pakrym-oai
pakrym-oai reviewed Apr 14, 2026
View reviewed changes
Comment thread codex-rs/core/tests/common/test_codex.rs Outdated
pakrym-oai
pakrym-oai reviewed Apr 14, 2026
View reviewed changes
Comment thread codex-rs/core/tests/suite/apply_patch_cli.rs
pakrym-oai
pakrym-oai reviewed Apr 14, 2026
View reviewed changes
Comment thread codex-rs/core/tests/suite/apply_patch_cli.rs Outdated
@starr-openai starr-openai force-pushed the starr/remote-full-ci-minimal-20260414 branch from 2f30428 to c7e4917 Compare April 15, 2026 00:33
@starr-openai starr-openai changed the title Fix remote full-ci test coverage Reuse remote exec-server in core tests Apr 15, 2026
@starr-openai starr-openai force-pushed the starr/remote-full-ci-minimal-20260414 branch from c7e4917 to cbf0fd8 Compare April 15, 2026 02:32
@starr-openai starr-openai force-pushed the starr/remote-full-ci-minimal-20260414 branch from cbf0fd8 to 6153e73 Compare April 15, 2026 02:47
@starr-openai starr-openai mentioned this pull request Apr 15, 2026
Closed
@starr-openai starr-openai merged commit e063596 into main Apr 15, 2026
41 of 50 checks passed
@starr-openai starr-openai deleted the starr/remote-full-ci-minimal-20260414 branch April 15, 2026 03:42
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pakrym-oai pakrym-oai pakrym-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@starr-openai @pakrym-oai