Skip to content

Fix remote skill popup loading#17702

Merged
starr-openai merged 1 commit into
mainfrom
starr-skill-popup-20260413130509
Apr 14, 2026
Merged

Fix remote skill popup loading#17702
starr-openai merged 1 commit into
mainfrom
starr-skill-popup-20260413130509

Conversation

@starr-openai

Copy link
Copy Markdown
Contributor

Summary

Fix the TUI $ skill popup so personal skills appear reliably when Codex is connected to a remote app-server.

What changed

  • load skills on TUI startup with an explicit forced refresh
  • refresh skills using the actual current cwd instead of an empty cwds list
  • resync an already-open $ popup when skill mentions are updated
  • add a regression test for refreshing an open mention popup

Root cause

The TUI was sometimes sending list_skills with cwds: [] after SessionConfigured.

For the launchd app-server flow, the server resolved that empty cwd list to its own process cwd, which was /. The response therefore came back tagged with cwd: "/", and the TUI later filtered skills by exact cwd match against the actual project cwd such as /Users/starr/code/dream. That dropped all personal skills from the mention list, so $ only showed plugins/apps.

Verification

Built successfully with remote cache disabled:

cd /Users/starr/code/codex-worktrees/starr-skill-popup-20260413130509
bazel --output_base=/tmp/codex-bazel-verify-starr-skill-popup build //codex-rs/cli:codex --noremote_accept_cached --noremote_upload_local_results --disk_cache=

Also verified interactively in a PTY against the live app-server at ws://127.0.0.1:4511:

  • launched the built TUI
  • typed $
  • confirmed personal skills appeared in the popup, including entries such as Applied Devbox, CI Debug, Channel Summarization, Codex PR Review, and Daily Digest

Files changed

  • codex-rs/tui/src/app.rs
  • codex-rs/tui/src/chatwidget.rs
  • codex-rs/tui/src/bottom_pane/chat_composer.rs

Ensure TUI skill refreshes use the active cwd so remote app-server responses are matched correctly, refresh skills on startup, and resync open mention popups when skill data arrives.

Co-authored-by: Codex <noreply@openai.com>
@starr-openai starr-openai marked this pull request as ready for review April 13, 2026 22:25

@etraut-openai etraut-openai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for fixing this.

@starr-openai starr-openai merged commit 706f830 into main Apr 14, 2026
21 of 22 checks passed
@starr-openai starr-openai deleted the starr-skill-popup-20260413130509 branch April 14, 2026 19:49
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants