Stabilize exec-server filesystem tests in CI#17671
Merged
Merged
Conversation
0d1d255 to
b3aa1a4
Compare
pakrym-oai
reviewed
Apr 13, 2026
| use std::path::Path; | ||
|
|
||
| fn main() -> Result<(), Box<dyn Error + Send + Sync>> { | ||
| #[cfg(target_os = "linux")] |
Collaborator
There was a problem hiding this comment.
would be nice to break circular dep and use arg0 helper directly. not blocking.
Contributor
Author
There was a problem hiding this comment.
going to try to refactor and share the same test setup core is using for the same purposes
pakrym-oai
approved these changes
Apr 13, 2026
0680ffd to
04e577c
Compare
Move the arg0-based test-binary dispatch bootstrap into a shared test-only crate so core and exec-server can reuse the same current_exe-based harness without keeping exec-server-specific helper logic in codex-arg0. Co-authored-by: Codex <noreply@openai.com>
04e577c to
b5bee4c
Compare
Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- add an exec-server package-local test helper binary that can run exec-server and fs-helper flows\n- route exec-server filesystem tests through that helper instead of cross-crate codex helper binaries\n- stop relying on Bazel-only extra binary wiring for these tests\n\n## Testing\n- not run (per repo guidance for codex changes)