bazel: Always save bazel repository cache#16926
Merged
Merged
Conversation
zbarsky-openai
approved these changes
Apr 6, 2026
| # never fails the overall job. Only save when key wasn't hit. | ||
| - name: Save bazel repository cache | ||
| if: always() && !cancelled() && steps.cache_bazel_repository_restore.outputs.cache-hit != 'true' | ||
| if: always() |
Contributor
There was a problem hiding this comment.
probably can snip this line fully
Collaborator
Author
There was a problem hiding this comment.
then it will be skipped if prior step failed a test?
Collaborator
Author
There was a problem hiding this comment.
probably should return !cancelled() back, hm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should improve the cache hit ratio for external deps and such