Skip to content

[Rust] Allow resuming a session that was killed with ctrl + c#1387

Merged
gpeal merged 5 commits into
mainfrom
gpeal/graceful-interruption-3
Jun 26, 2025
Merged

[Rust] Allow resuming a session that was killed with ctrl + c#1387
gpeal merged 5 commits into
mainfrom
gpeal/graceful-interruption-3

Conversation

@gpeal

@gpeal gpeal commented Jun 25, 2025

Copy link
Copy Markdown
Collaborator

Previously, if you ctrl+c'd a conversation, all subsequent turns would 400 because the Responses API never got a response for one of its call ids. This ensures that if we aren't sending a call id by hand, we generate a synthetic aborted call.

Fixes #1244

CleanShot.2025-06-25.at.16.51.57.mp4

@gpeal gpeal requested review from bolinfest and fouad-openai June 25, 2025 21:06

@bolinfest bolinfest left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, though please check CI failures!

Comment thread codex-rs/core/src/client.rs Outdated
Comment thread codex-rs/core/src/client_common.rs Outdated
Comment thread codex-rs/core/src/codex.rs Outdated
Comment thread codex-rs/core/src/codex.rs Outdated
Comment thread codex-rs/core/src/codex.rs Outdated
@gpeal gpeal merged commit a339a7b into main Jun 26, 2025
11 checks passed
@gpeal gpeal deleted the gpeal/graceful-interruption-3 branch June 26, 2025 18:40
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hitting Ctrl+C once should interrupt the model and give you a chance to redirect it

2 participants