Preserve persisted thread git info in resume#13504
Conversation
owenlin0
left a comment
There was a problem hiding this comment.
this code currently feels very special-cased for gitinfo. I think there's actually a structural problem with thread/resume - codex suggests this, which I think is a great idea:
The cleaner approach is to make resume build Thread the same way
thread/readalready does: prefer DB-backed summary for mutable metadata, then layer rollout-derived turns on top, and merge the active turn for the running-thread case. That removes the git special case entirely.
Want to take a stab at this?
|
@owenlin0 Very fair comment! changing now |
This reverts commit 9cb3ead.
…odex-fix-appserver-thread-resume
|
It seems like we now have a few methods that look similar:
I think we can make it cleaner. Codex suggests this:
|
|
that said, pre-approving. much better already, thanks! |
Summary
thread.resumereuses the storedgitInfoinstead of rebuilding it from the live working treeTesting