Skip to content

test: move unix_escalation tests into sibling file#12957

Merged
bolinfest merged 1 commit intomainfrom
pr12957
Feb 26, 2026
Merged

test: move unix_escalation tests into sibling file#12957
bolinfest merged 1 commit intomainfrom
pr12957

Conversation

@bolinfest
Copy link
Collaborator

@bolinfest bolinfest commented Feb 26, 2026

Why

unix_escalation.rs had a large inline mod tests block that made the implementation harder to scan. This change moves those tests into a sibling file while keeping them as a child module, so they can still exercise private items without widening visibility.

What Changed

  • replaced the inline #[cfg(test)] mod tests block in codex-rs/core/src/tools/runtimes/shell/unix_escalation.rs with a path-based test module declaration
  • moved the existing unit tests into codex-rs/core/src/tools/runtimes/shell/unix_escalation_tests.rs
  • kept the extracted tests using super::... imports so they continue to access private helpers and types from unix_escalation.rs

Testing

  • cargo test -p codex-core unix_escalation::tests

@bolinfest bolinfest enabled auto-merge (squash) February 26, 2026 23:10
@bolinfest bolinfest merged commit 4cb086d into main Feb 26, 2026
59 of 65 checks passed
@bolinfest bolinfest deleted the pr12957 branch February 26, 2026 23:15
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants