Add a background job to refresh the requirements local cache#12936
Add a background job to refresh the requirements local cache#12936alexsong-oai merged 6 commits intomainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1c3c4adc5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| } | ||
|
|
||
| async fn refresh_cache(&self) { |
There was a problem hiding this comment.
can we just use fetch_with_timeout or somehow dry the logic a little bit?
There was a problem hiding this comment.
this fn already reuses fetch_with_retries for the core fetch logic. The rest is just deriving the required params.
| data: None, | ||
| }); | ||
| } | ||
| stop_cloud_requirements_refresher(); |
There was a problem hiding this comment.
Can the refresh job detect this and exit on its own (i.e., be more self-maintaining)?
There was a problem hiding this comment.
maybe just quit the refresh_cache_in_background loop once self.auth_manager.auth() failed?
Uh oh!
There was an error while loading. Please reload this page.