tui: use thread_id for resume/fork cwd resolution by charley-oai · Pull Request #12727 · openai/codex

charley-oai · 2026-02-25T00:21:37Z

Summary

make resume/fork targets explicit and typed as SessionTarget { path, thread_id } (non-optional thread_id)
resolve thread_id centrally via resolve_session_thread_id(...):
- use CLI input directly when it is a UUID (--resume <uuid> / --fork <uuid>)
- otherwise read thread_id from rollout SessionMeta for path-based selections (picker, --resume-last, name-based resume/fork)
use thread_id to read cwd from SQLite first during resume/fork cwd resolution
keep rollout fallback for cwd resolution when SQLite is unavailable or does not return thread metadata (TurnContext tail, then SessionMeta)
keep the resume picker open when a selected row has unreadable session metadata, and show an inline recoverable error instead of aborting the TUI

Why

This removes ad-hoc rollout filename parsing and makes resume/fork target identity explicit. The resume/fork cwd check can use indexed SQLite lookup by thread_id in the common path, while preserving rollout-based fallback behavior. It also keeps malformed legacy rows recoverable in the picker instead of letting a selection failure unwind the app.

Notes

minimal TUI-only change; no schema/protocol changes
includes TUI test coverage for SQLite cwd precedence when thread_id is available
includes TUI regression coverage for picker inline error rendering / non-fatal unreadable session rows

Codex author

codex resume 019c9205-7f8b-7173-a2a2-f082d4df3de3

charley-oai · 2026-02-25T00:24:42Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b012c108e0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/lib.rs

charley-oai · 2026-02-25T01:45:58Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a24b8dba8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/lib.rs

charley-oai · 2026-02-25T02:53:12Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e6e478aa51

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-25T02:56:49Z

codex-rs/tui/src/lib.rs

+            Ok(Some(path)) => match resolve_session_thread_id(path.as_path(), None).await {
+                Some(thread_id) => {
+                    resume_picker::SessionSelection::Resume(resume_picker::SessionTarget {
+                        path,
+                        thread_id,
+                    })
+                }
+                None => {
+                    let rollout_path = path.display();


Keep resume/fork working when SessionMeta is missing

--resume-last now hard-fails when resolve_session_thread_id(...) returns None. That resolver depends on read_session_meta_line, which errors if a rollout does not start with SessionMeta (legacy or malformed files). These sessions can still be resumed/forked by path, and cwd can still be derived from rollout fallback, so this introduces a regression that blocks session recovery.

Useful? React with 👍 / 👎.

@jif-oai do we want to support rollout files without a session meta?

codex-rs/tui/src/resume_picker.rs

charley-oai · 2026-02-25T03:12:44Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d70f433d32

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/resume_picker.rs

chatgpt-codex-connector · 2026-02-25T03:17:50Z

codex-rs/tui/src/lib.rs

+        None => read_session_meta_line(path)
+            .await
+            .ok()
+            .map(|meta_line| meta_line.meta.id),


Resolve thread id from full rollout scan, not head-only parse

resolve_session_thread_id(..., None) relies on read_session_meta_line, which requires SessionMeta at the very first rollout line. Resume/fork loading accepts the first SessionMeta anywhere in the file, so path-based flows (--resume-last, --fork-last, name-based resume/fork) can now reject sessions that are still resumable when head lines are malformed or reordered.

Useful? React with 👍 / 👎.

I think this is not worth worrying about

charley-oai · 2026-02-25T03:38:47Z

@codex review this

chatgpt-codex-connector · 2026-02-25T03:43:51Z

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jif-oai · 2026-02-25T15:00:05Z

@codex review

jif-oai

I'm not sure this is a good idea as it let users resuming sessions outside of ~/.config/sessions
What was the rational behind doing this?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf6ac10a76

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/lib.rs

chatgpt-codex-connector bot reviewed Feb 25, 2026

View reviewed changes

codex-rs/tui/src/lib.rs Show resolved Hide resolved

charley-oai added 6 commits February 24, 2026 17:24

tui: use thread id for resume/fork cwd lookup

6fe1f66

tui: require thread ids for resume and fork targets

37a7d75

tui: resolve session thread ids from session metadata

ebb19ee

tui: inline session thread id resolution

9ccd715

tui: dedupe resume/fork thread id resolution

02b4559

tui: fix import ordering after rebase

a24b8db

charley-oai force-pushed the cc/thread-id-cwd-resume branch from 62c68e8 to a24b8db Compare February 25, 2026 01:29

github-actions bot mentioned this pull request Feb 25, 2026

📊 AI CLI 工具社区动态日报 2026-02-25 duanyytop/agents-radar#9

Open

chatgpt-codex-connector bot reviewed Feb 25, 2026

View reviewed changes

codex-rs/tui/src/lib.rs Outdated Show resolved Hide resolved

tui: fail --resume-last/--fork-last on unreadable metadata

e6e478a

charley-oai marked this pull request as ready for review February 25, 2026 02:53

chatgpt-codex-connector bot reviewed Feb 25, 2026

View reviewed changes

tui: error when picker selection lacks thread metadata

d70f433

chatgpt-codex-connector bot reviewed Feb 25, 2026

View reviewed changes

Keep resume picker open on unreadable sessions

cf6ac10

jif-oai reviewed Feb 25, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Feb 25, 2026

View reviewed changes

codex-rs/tui/src/lib.rs Show resolved Hide resolved

jif-oai approved these changes Feb 26, 2026

View reviewed changes

github-actions bot mentioned this pull request Feb 26, 2026

📊 AI CLI 工具社区动态日报 2026-02-26 duanyytop/agents-radar#17

Open

charley-oai merged commit c1afb88 into main Feb 26, 2026
31 of 33 checks passed

charley-oai deleted the cc/thread-id-cwd-resume branch February 26, 2026 20:52

github-actions bot locked and limited conversation to collaborators Feb 26, 2026

Conversation

charley-oai commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Notes

Codex author

Uh oh!

charley-oai commented Feb 25, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Feb 25, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Feb 25, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

charley-oai Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

charley-oai commented Feb 25, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

charley-oai Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

charley-oai commented Feb 25, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 25, 2026

Uh oh!

jif-oai commented Feb 25, 2026

Uh oh!

jif-oai left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

charley-oai commented Feb 25, 2026 •

edited

Loading