fix(linux-sandbox): mount /dev in bwrap sandbox#12081
Merged
viyatb-oai merged 23 commits intomainfrom Feb 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd344ee51e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bolinfest
reviewed
Feb 18, 2026
bolinfest
reviewed
Feb 18, 2026
| if let Some(first_missing) = find_first_non_existent_component(&subpath) | ||
| && is_within_allowed_write_paths(&first_missing, &allowed_write_paths) | ||
| { | ||
| args.push("--ro-bind".to_string()); |
Collaborator
There was a problem hiding this comment.
Why is this inside this loop?
Collaborator
Author
There was a problem hiding this comment.
For each read-only path, this is adding its own --ro-bind ... protection.
--ro-bind /dev/null /repo/.git
--ro-bind /dev/null /repo/.codex
bolinfest
reviewed
Feb 18, 2026
bolinfest
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Linux bubblewrap sandbox args to mount a minimal
/devusing--dev /devinstead of only binding/dev/null. tools needing entropy (git, crypto libs, etc.) can fail.Changed mount order so
--dev /devis added before writable-root--bindmounts, preserving writable/dev/*submounts like/dev/shmWhy
Fixes sandboxed command failures when reading
/dev/urandom(and similar standard device-node access).Fixes #12056