Skip to content

Conversation

@revanthkumarJ
Copy link
Contributor

@revanthkumarJ revanthkumarJ commented Sep 3, 2025

Fixes - Jira-#528

WhatsApp.Video.2025-09-03.at.4.50.38.PM.mp4

@revanthkumarJ revanthkumarJ changed the title feat: App New Loan - Loan_Details_page feat:New Loan Account – Details Step Page Sep 3, 2025
@revanthkumarJ revanthkumarJ marked this pull request as ready for review September 3, 2025 11:26
@Nagarjuna0033
Copy link
Contributor

Nagarjuna0033 commented Sep 3, 2025

@revanthkumarJ See These changes going to break, see you are observing the network, and at the same time you are calling the other function in the init block concurrently so what is user doesn't have any internet connection still this will hit the Api and throws error which not handled properly in this case. and also validation is not up to mark. there is a field externalId you are just changing the value by invoking action is emojis and other invalid characters are allowed? if not you need to validate all those which is not handled in this pr and in upcoming prs also and why don't you separate the validations from onHandle function you are just implementing the logic in the same block which will be not readable. for example you ae doing like this

is NewLoanAccountAction.OnExternalIdChange -> {
                mutableStateFlow.update {
                    it.copy(
                        externalId = action.value,
                    )
                }
            }

but you can do like this

is NewLoanAccountAction.OnExternalIdChange -> handleExternalIdChange()

in the function you can validate every edge case and udpate the errors if any.

validations should be correctly handled and try out the feature in all cases like if user doesn't have internet or any other exception

write previews for all states

@therajanmaurya therajanmaurya merged commit 45f286a into openMF:development Sep 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants