fix(feat:client-identifiers): fix dialog visibility issues in client identifiers #2450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - MIFOSAC-498
Changes made in the PR:
Refactored dialog visibility logic for creating client identifiers:
Standardized success/error feedback: show toast on successful identifier creation and error UI on failures, all driven by a single sealed UI state and SharedFlow events.
Issue: Delete Identifier flow showed Loading twice;
Screenshots
Issue: Pull-to-refresh didn’t trigger loading on main screen; data refreshed silently.
Testing notes
Before:
before.mp4
After:
finalSol.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.