You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a variable shadowing issue: since a variable with the same name already exists in the function's input, the reasoning block incorrectly sets done to true at the beginning.
Fixed
Fixed variable shadowing in middleware
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.
We appreciate you taking the time to submit a pull request to Open WebUI!
⚠️ Important: Testing Requirements
We've recently seen an increase in PRs that have significant issues:
PRs that don't actually fix the bug they claim to fix
PRs that don't implement the feature they describe
PRs that break existing functionality
PRs that are clearly AI-generated without proper testing being done by the author
PRs that simply don't work as intended
These untested PRs consume significant time from maintainers and volunteer contributors who review and test PRs in their free time.
Time that could be spent testing other PRs or improving Open WebUI in other ways.
Before marking your PR as "Ready for Review":
Please explicitly confirm:
✅ You have personally tested ALL changes in this PR
✅ How you tested it (specific steps you took to verify it works)
✅ Visual evidence where applicable (screenshots or videos showing the feature/fix working) - if applicable to your specific PR
If you're not certain your PR works exactly as intended, please leave it in DRAFT mode until you've thoroughly tested it.
Thank you for helping us maintain quality and respecting the time of our community! 🙏
⚠️ Warning: Possible Non-Atomic / Scope Creep PR Detected
Your PR was subjected to automated review by AI to determine if it could fall under Open WebUI's non-atomicity ruleset or scope creep.
This PR appears to contain multiple unrelated changes that could be split into separate pull requests.
🔍 AI Analysis Summary
Primary Intent: Variable renaming to fix potential shadowing in serialize_output function
Secondary Changes Detected:
None identified
📝 Detailed Analysis and Full Report (click to expand)
This PR makes a pure variable renaming refactor: changing loop variable 'output' to 'out' to avoid shadowing the outer 'output' parameter. While this is a single file change, it qualifies as a 'Pre-factor' refactoring that could have been merged independently. The change has no dependency on any feature work and could have been submitted as a standalone code cleanup PR. Since can_be_split is true (this refactor could exist as its own PR), the PR is NOT atomic according to the strict enforcement rules, even though no feature is being bundled.
Why Atomic PRs With Narrow Scopes Matter
Atomic PRs (single-purpose PRs) are:
Easier to review - Reviewers can focus on one thing at a time
Easier to test - Each change can be verified independently
Easier to revert - If something breaks, we can revert just the problematic change
Faster to merge - Smaller, focused PRs get reviewed and merged quicker
What Makes a PR Atomic / Narrow in Scope?
An atomic PR should contain one semantic change:
✅ Just one bug fix (even if it touches multiple files)
✅ Just one feature (even if it requires changes across multiple files)
✅ Just i18n/translation updates
✅ Just documentation updates
✅ Just refactoring of one specific thing
✅ Just one performance improvement
What To Do
This is an automated analysis. If you believe this assessment is incorrect and your PR is actually atomic (all changes serve one unified purpose), please explain in a comment below.
Consider splitting this PR into separate, focused pull requests. Each PR should address one specific thing.
For example, if you have a bug fix and a new feature, submit them as two separate PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
reasoningblock incorrectly setsdonetotrueat the beginning.Fixed
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.