Skip to content

refactor: Single Toast after bulk updates#21958

Closed
pljones wants to merge 1 commit intoopen-webui:devfrom
pljones:refactor/hide-show-all-models
Closed

refactor: Single Toast after bulk updates#21958
pljones wants to merge 1 commit intoopen-webui:devfrom
pljones:refactor/hide-show-all-models

Conversation

@pljones
Copy link
Contributor

@pljones pljones commented Feb 28, 2026 •
edited
Loading

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. N/A
  • Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. N/A
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. None
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
  • Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Currently, Enable/Disable all models issues no toast
  • Currently, Show/Hide all models issues two toasts per model
  • This change refactors all four functions to be consistent and issue a single toast on successful operation

Added

  • New toast after successful Enable/Disable all models

Changed

  • Single toast after successful Show/Hide all models

Deprecated

  • None

Removed

  • None

Fixed

  • None

Security

  • None

Breaking Changes

  • BREAKING CHANGE: None

Additional Information

Screenshots or Videos

  • N/A

Before - Hide All models
https://github.com/user-attachments/assets/90f5d1b8-f622-49ab-9372-048c8e697e76

image

Before - Disable All models
https://github.com/user-attachments/assets/c9eff037-0278-42e9-b576-5838e4f808fe

(No toasts)

After - Hide All models

Screen.Recording.2026-02-28.093750.mp4
image

After - Disable All models

Screen.Recording.2026-02-28.093950.mp4
image

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

@pr-validator-bot
Copy link

pr-validator-bot commented Feb 28, 2026

👋 Welcome and Thank You for Contributing!

We appreciate you taking the time to submit a pull request to Open WebUI!

⚠️ Important: Testing Requirements

We've recently seen an increase in PRs that have significant issues:

  • PRs that don't actually fix the bug they claim to fix
  • PRs that don't implement the feature they describe
  • PRs that break existing functionality
  • PRs that are clearly AI-generated without proper testing being done by the author
  • PRs that simply don't work as intended

These untested PRs consume significant time from maintainers and volunteer contributors who review and test PRs in their free time.
Time that could be spent testing other PRs or improving Open WebUI in other ways.

Before marking your PR as "Ready for Review":

Please explicitly confirm:

  1. ✅ You have personally tested ALL changes in this PR
  2. ✅ How you tested it (specific steps you took to verify it works)
  3. ✅ Visual evidence where applicable (screenshots or videos showing the feature/fix working) - if applicable to your specific PR

If you're not certain your PR works exactly as intended, please leave it in DRAFT mode until you've thoroughly tested it.

Thank you for helping us maintain quality and respecting the time of our community! 🙏

@pljones pljones changed the title Refactor: Single Toast after bulk updates refactor: Single Toast after bulk updates Feb 28, 2026
@pr-validator-bot
Copy link

pr-validator-bot commented Feb 28, 2026

⚠️ Warning: Possible Non-Atomic / Scope Creep PR Detected

Your PR was subjected to automated review by AI to determine if it could fall under Open WebUI's non-atomicity ruleset or scope creep.

This PR appears to contain multiple unrelated changes that could be split into separate pull requests.

🔍 AI Analysis Summary

Primary Intent: Enhance bulk model management actions (enable all, disable all, show all, hide all) with error handling, success toasts, guard clauses, and corrected API calls

Secondary Changes Detected:

  • Add error handling with .catch() to Promise.all calls
  • Add success toast notifications for each bulk operation
  • Add guard clauses (if modelsToX.length) to prevent unnecessary API calls
  • Fix API function: change upsertModelHandler to updateModelById for show/hide operations
  • Minor filter logic refinements (parentheses cleanup)
📝 Detailed Analysis and Full Report (click to expand)

While all changes touch the same file and relate to bulk model management, they represent multiple distinct improvements that could have been merged separately: (1) The guard clauses and filter logic changes could be a separate PR for defensive coding, (2) The error handling (.catch) could be merged independently, (3) The toast notifications could be added as a separate enhancement PR, and (4) The API fix (upsertModelHandler -> updateModelById) could potentially be a standalone fix. The 'Pre-factor' test asks: could error handling/toasts have been added as a separate PR BEFORE this feature was merged? Yes - these are additive improvements that don't fundamentally change the feature's nature. However, since they're all in the same file and related to the same feature area, this is a borderline case. The strongest argument for splitting would be that error handling and toasts are cross-cutting concerns that could apply to many similar handlers, making them candidates for separate PRs.

Why Atomic PRs With Narrow Scopes Matter

Atomic PRs (single-purpose PRs) are:

  • Easier to review - Reviewers can focus on one thing at a time
  • Easier to test - Each change can be verified independently
  • Easier to revert - If something breaks, we can revert just the problematic change
  • Faster to merge - Smaller, focused PRs get reviewed and merged quicker

What Makes a PR Atomic / Narrow in Scope?

An atomic PR should contain one semantic change:

  • ✅ Just one bug fix (even if it touches multiple files)
  • ✅ Just one feature (even if it requires changes across multiple files)
  • ✅ Just i18n/translation updates
  • ✅ Just documentation updates
  • ✅ Just refactoring of one specific thing
  • ✅ Just one performance improvement

What To Do

This is an automated analysis. If you believe this assessment is incorrect and your PR is actually atomic (all changes serve one unified purpose), please explain in a comment below.

Consider splitting this PR into separate, focused pull requests. Each PR should address one specific thing.

For example, if you have a bug fix and a new feature, submit them as two separate PRs.

@pljones
Copy link
Contributor Author

pljones commented Feb 28, 2026 •
edited
Loading

To follow:

Both of those are ready and tested, too.

@pljones
Copy link
Contributor Author

pljones commented Feb 28, 2026

That "Detailed Analysis and Full Report (click to expand)" is pretty neat. Yes, it was a choice to keep it all in this one PR -- mostly as ground work for the second "refactor again" PR to make the code "ready". I guess this does muddy "add some value" (get rid of those multiple toasts) with all the other improvements that could have been left until the second PR tore everything apart.

However, I think it's actually easier to follow the development of the code in the way I've split it.

@tjbck
Copy link
Contributor

tjbck commented Feb 28, 2026

Addressed in dev.

@tjbck tjbck closed this Feb 28, 2026
@pljones pljones deleted the refactor/hide-show-all-models branch March 1, 2026 10:15
@gemini-code-assist gemini-code-assist bot mentioned this pull request Mar 2, 2026
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pljones @pr-validator-bot @tjbck