fix: circular import in groups.py breaks migrations#21848
Closed
Algorithm5838 wants to merge 1 commit intoopen-webui:devfrom
Closed
fix: circular import in groups.py breaks migrations#21848Algorithm5838 wants to merge 1 commit intoopen-webui:devfrom
Algorithm5838 wants to merge 1 commit intoopen-webui:devfrom
Conversation
Move the DEFAULT_GROUP_SHARE_PERMISSION import from module level into the two methods that use it. The top-level import created a cycle: users -> groups -> config -> run_migrations -> auths -> users. Migrations failed silently on startup.
👋 Welcome and Thank You for Contributing!We appreciate you taking the time to submit a pull request to Open WebUI!
|
Collaborator
|
Can reproduce |
11 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the DEFAULT_GROUP_SHARE_PERMISSION import from module level into the two methods that use it. The top-level import created a cycle: users -> groups -> config -> run_migrations -> auths -> users. Migrations failed silently on startup.
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.
This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.
Before submitting, make sure you've checked the following:
devbranch. PRs targetingmainwill be immediately closed.devto ensure no unrelated commits (e.g. frommain) are included. Push updates to the existing PR branch instead of closing and reopening.Changelog Entry
Description
Commit 538501c added
from open_webui.config import DEFAULT_GROUP_SHARE_PERMISSIONat module level ingroups.py. This created a circular import:The
except Exceptioninrun_migrations()swallows theImportError, so the app starts but migrations never run. New schema changes from the release are not applied.The fix makes the import lazy by moving it inside
_ensure_default_share_configandcreate_groups_by_group_names, the only two methods that use it.Added
Changed
Deprecated
Removed
Fixed
Security
Breaking Changes
Additional Information
Screenshots or Videos
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.