Fix: new Environment variable OAUTH_DEFAULT_GROUP_PERMISSIONS & default Group behavior of {"config": {"share": False}} for sharing when new group created via oAuth#21679
Closed
antpar-rf wants to merge 4 commits intoopen-webui:devfrom
Conversation
OAUTH_DEFAULT_GROUP_PERMISSIONS for config file of 'members', 'anyone' or 'noone' OAUTH_DEFAULT_GROUP_PERMISSIONS=none default behavior is none if not set
Fix: Add Oauth Group Permission logic for new groups based off of permissions environment model by default . If not set, sets to noone as best form of secops.
OAUTH_DEFAULT_GROUP_PERMISSIONS = 'members' , 'noone' or 'anyone'
data=group_data_payload,
```
group_data_payload = {}
oauth_default_permission = (
auth_manager_config.OAUTH_DEFAULT_GROUP_PERMISSIONS
)
if oauth_default_permission:
if oauth_default_permission.lower() == "members":
group_data_payload = {"config": {"share": "members"}}
elif oauth_default_permission.lower() == "noone":
group_data_payload = {"config": {"share": False}}
elif oauth_default_permission.lower() == "anyone":
group_data_payload = {"config": {"share": True}}
else:
log.warning(
f"Unknown OAUTH_DEFAULT_GROUP_PERMISSIONS value: {oauth_default_permission}. "
"Using empty data payload."
)
group_data_payload = {"config": {"share": False}}
log.debug(
f"Group data payload for OAuth group creation: {group_data_payload}"
)
```
Sync to existing dev from 0.8.3
OAUTH_MAX_SESSIONS_PER_USER
👋 Welcome and Thank You for Contributing!We appreciate you taking the time to submit a pull request to Open WebUI!
|
11 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: OAUTH_DEFAULT_GROUP_PERMISSIONS
Add oAuth Group Permission logic for new groups based off of permissions environment model by default . If not set, sets to noone as best form of secops.
OAUTH_DEFAULT_GROUP_PERMISSIONS = 'members' , 'noone' or 'anyone'
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.