Conversation
fix: mcp ssl check
Typography issue correction Co-authored-by: Tim Baek <tim@openwebui.com> Co-authored-by: joaoback <156559121+joaoback@users.noreply.github.com>
RFC 7644 §3.4.2.4 specifies that out-of-range pagination values MUST be clamped, not rejected. The previous implementation used FastAPI Query constraints (ge=1, le=100) which caused a 422 response for values like startIndex=0 or count=9999 — violating the spec. For both /Users and /Groups: - startIndex < 1 is now treated as 1 (spec: "SHALL be interpreted as 1") - count < 0 is now treated as 0 (spec: "SHALL be interpreted as 0") - count > 100 is clamped to the server maximum of 100 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
The GET /chats/shared endpoint was loading full Chat rows including the entire conversation history JSON blob, only to discard it and return SharedChatResponse (id, title, share_id, timestamps). Now uses with_entities() to select only the 5 needed columns, avoiding deserialization of potentially large chat JSON for every shared chat.
Co-authored-by: :o <52920416+gg0h@users.noreply.github.com>
… pass (#21527) Translate all remaining untranslated strings to Brazilian Portuguese (pt-BR) Translated ~100 previously untranslated entries (empty "" values) across the Open WebUI i18n JSON file. Changes include: Translated UI labels, form fields, tooltips, and error messages Kept brand/product names unchanged where appropriate (e.g., Bing, Brave, Gemini, OpenAI, YouTube) Translated technical terms with context-appropriate Brazilian Portuguese equivalents (e.g., "Timeout" → "Tempo limite", "Config" → "Configuração", "Endpoint URL" → "URL do Endpoint") Added translations for search engine integrations (Kagi, Perplexity, SerpApi, Tavily, Yacy, Yandex, etc.) Translated plural forms for source retrieval messages (sources_one, sources_many, sources_other) No untranslated entries remain in the file.
Added missing translations.
… append+reverse (#21588) Co-authored-by: Jordan <CenteredAxis@users.noreply.github.com>
* feat: add LOG_FORMAT env var with JSON formatter for early logging Introduce LOG_FORMAT environment variable (set to "json" to enable). When active, logging.basicConfig() uses a JSONFormatter that outputs single-line JSON objects with fields: ts, level, msg, caller, error, stacktrace. This covers all log messages emitted during module imports before Loguru's start_logger() takes over. * feat: add JSON sink for Loguru when LOG_FORMAT=json Add _json_sink() as a Loguru sink function that writes single-line JSON to stdout. In start_logger(), conditionally use the JSON sink instead of the plain-text stdout_format when LOG_FORMAT is set to "json". * feat: suppress ASCII banner and fix alembic logging in JSON mode - Wrap the ASCII art banner print in main.py with a LOG_FORMAT != "json" guard so JSON output stays machine-parseable. - Skip alembic's fileConfig() call in migrations/env.py when LOG_FORMAT=json to prevent it from replacing the JSON log handlers installed during early startup.
* changelog: add prompt enable/disable toggle entry * changelog: fix PostgreSQL workspace cloning * changelog: MCP SSL verification fix * changelog: mcp ssl, general improvements, french translations * changelog: add memory deletion and listing tools for agents * changelog: add embeddings and proxy timeout fix for PR #21558 * changelog: pip requirements toggle * changelog: fix commit references for memory and MCP entries * changelog: scim, parameter handling, rfc7644 * changelog: update iframe sandbox entry for clarity * changelog: shared chat optimization, translation updates * changelog: file access control respect fix * changelog: chat title query optimization, shared chat loading * changelog: hybrid search fix, Finnish translations * changelog: message list performance optimization * changelog: archived chats, pinned chats, loading optimization * changelog: knowledge-base-import, overwrite-flag, API-enhancement * changelog: message upsert and tag filtering optimizations * changelog: batch access grants, notes payload optimization * changelog: skill import, json support * changelog: add fix for imported items display issue * changelog: add Anthropic Messages API proxy support * changelog: WebSocket race condition fix for collaborative editing * 📝 * changelog: drag-drop, firefox, overlay fix * changelog: add multi-device OAuth sessions feature * changelog: cyclic chat history deadlock fix * changelog: group search visibility fix * changelog: model default feature permissions * changelog: admin groups sorting, notes optimization * changelog: model selector, virtual scroll, UI fix * changelog: user menu drag and click fixes * changelog: rich-ui, auto-scroll, ux * changelog: enhance Anthropic Messages API proxy with tool call support * changelog: embedding concurrency, knowledge import * changelog: add You.com web search provider (#21599) * changelog: admin analytics toggle * changelog: console log spam fix * changelog: fetch URL citation sources * changelog: message send optimization * changelog: oauth, group sharing, settings * changelog: admin nav drag fix (PR #21701) * changelog: signup race condition, security fix * changelog: playground, nav, drag * changelog: group description, sort dropdown * changelog: add model selector accessibility improvements * changelog: consolidate accessibility entries for PRs #21705 and #21706 * changelog: tools list performance optimization * changelog: accessibility, components, wcag * changelog: button accessibility labels, wcag compliance * changelog: Firefox avatar overflow fix * changelog: disabled model cloning prevention fix * changelog: dark mode select background fix * changelog: update date to 2026-02-22, consolidate accessibility entries * changelog: new chat message handling fix * changelog: accessibility, aria-labels, settings components * changelog: admin settings, tab navigation * changelog: scroll, messages, deletion * changelog: scroll, chat, message fixes * changelog: model fallback routing and default model selection fixes * changelog: remove duplicate scroll jumping fix from 0.8.3 * changelog: model visibility badges * changelog: prompt import fix * changelog: dropdown menu drag fix * changelog: add workspace accessibility improvements to UI accessibility entry * changelog: docker hub integration * changelog: global model defaults, admin settings * changelog: text file type detection fix * changelog: update date to 2026-02-23 * changelog: ollama reasoning effort fix * changelog: emoji deduplication in Fixed section * changelog: sql, warning-fix * changelog: add plaintext tool output display entry
…l setting… (#21742) * Allow empty LDAP Application DN value and password in General settings form * fix(ui): use LDAP app_dn, app_dn_password with empty string instead of enforcing non-empty values
…ive anchor tags for robust new-tab link capabilities (#21723)
…event text highlighting (#21763)
* changelog: add prompt enable/disable toggle entry * changelog: fix PostgreSQL workspace cloning * changelog: MCP SSL verification fix * changelog: mcp ssl, general improvements, french translations * changelog: add memory deletion and listing tools for agents * changelog: add embeddings and proxy timeout fix for PR #21558 * changelog: pip requirements toggle * changelog: fix commit references for memory and MCP entries * changelog: scim, parameter handling, rfc7644 * changelog: update iframe sandbox entry for clarity * changelog: shared chat optimization, translation updates * changelog: file access control respect fix * changelog: chat title query optimization, shared chat loading * changelog: hybrid search fix, Finnish translations * changelog: message list performance optimization * changelog: archived chats, pinned chats, loading optimization * changelog: knowledge-base-import, overwrite-flag, API-enhancement * changelog: message upsert and tag filtering optimizations * changelog: batch access grants, notes payload optimization * changelog: skill import, json support * changelog: add fix for imported items display issue * changelog: add Anthropic Messages API proxy support * changelog: WebSocket race condition fix for collaborative editing * 📝 * changelog: drag-drop, firefox, overlay fix * changelog: add multi-device OAuth sessions feature * changelog: cyclic chat history deadlock fix * changelog: group search visibility fix * changelog: model default feature permissions * changelog: admin groups sorting, notes optimization * changelog: model selector, virtual scroll, UI fix * changelog: user menu drag and click fixes * changelog: rich-ui, auto-scroll, ux * changelog: enhance Anthropic Messages API proxy with tool call support * changelog: embedding concurrency, knowledge import * changelog: add You.com web search provider (#21599) * changelog: admin analytics toggle * changelog: console log spam fix * changelog: fetch URL citation sources * changelog: message send optimization * changelog: oauth, group sharing, settings * changelog: admin nav drag fix (PR #21701) * changelog: signup race condition, security fix * changelog: playground, nav, drag * changelog: group description, sort dropdown * changelog: add model selector accessibility improvements * changelog: consolidate accessibility entries for PRs #21705 and #21706 * changelog: tools list performance optimization * changelog: accessibility, components, wcag * changelog: button accessibility labels, wcag compliance * changelog: Firefox avatar overflow fix * changelog: disabled model cloning prevention fix * changelog: dark mode select background fix * changelog: update date to 2026-02-22, consolidate accessibility entries * changelog: new chat message handling fix * changelog: accessibility, aria-labels, settings components * changelog: admin settings, tab navigation * changelog: scroll, messages, deletion * changelog: scroll, chat, message fixes * changelog: model fallback routing and default model selection fixes * changelog: remove duplicate scroll jumping fix from 0.8.3 * changelog: model visibility badges * changelog: prompt import fix * changelog: dropdown menu drag fix * changelog: add workspace accessibility improvements to UI accessibility entry * changelog: docker hub integration * changelog: global model defaults, admin settings * changelog: text file type detection fix * changelog: update date to 2026-02-23 * changelog: ollama reasoning effort fix * changelog: emoji deduplication in Fixed section * changelog: sql, warning-fix * changelog: add plaintext tool output display entry * changelog: json, logging, format * changelog: RAG template mutation fix for sequential tool calls * changelog: analytics sorting, ldap authentication * changelog: API tools, LDAP fields, SQLAlchemy fixes * changelog: add folder menu fix, event call input masking, analytics sorting, LDAP fix, SQL warning fix * changelog: add prompt suggestions and banners moved entries * changelog: add prompt suggestions and banners moved to current version * changelog: improve prompt suggestions and banners moved entries * changelog: add hybrid search deduplication fix
bdrosen96
reviewed
Feb 25, 2026
| if name not in tools_dict: | ||
| tools_dict[name] = tool_dict | ||
|
|
||
| if tools_dict: |
There was a problem hiding this comment.
Did you intend for the else on line 2534 to be aligned with if tools_dict or should it also have been indented to be aligned with line 2526 like it was before the refactor? I noticed that when I got this updated code, some models no longer return responses as fast as they did before this went in
There was a problem hiding this comment.
When I locally modify the file and indent it to be like it was before, it restores the old behavior so I tend to think this is a regression as it invokes tools when tools_dict is empty and ends up using stream=False when calling generate_chat_completion instead of stream=True
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.