fix: Use keyword argument for IndicesClient.refresh() opensearch-py >= 3.0.0#20748
Closed
YuriNachos wants to merge 1 commit intoopen-webui:devfrom
Closed
fix: Use keyword argument for IndicesClient.refresh() opensearch-py >= 3.0.0#20748YuriNachos wants to merge 1 commit intoopen-webui:devfrom
YuriNachos wants to merge 1 commit intoopen-webui:devfrom
Conversation
…= 3.0.0 Fixes open-webui#20649 In opensearch-py >= 3.0.0, the IndicesClient.refresh() method signature changed to only accept keyword-only arguments. The previous code called it with a positional argument, causing TypeError. Changed: self.client.indices.refresh(self._get_index_name(collection_name)) To: self.client.indices.refresh(index=self._get_index_name(collection_name)) This fix is applied to all occurrences in the OpenSearchClient class.
👋 Welcome and Thank You for Contributing!We appreciate you taking the time to submit a pull request to Open WebUI!
|
Collaborator
|
Did you test this? |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
Changed
IndicesClient.refresh()calls to use keyword argumentindex=instead of positional argumentDeprecated
Removed
Fixed
IndicesClient.refresh()method signature changed to only accept keyword-only argumentsself.client.indices.refresh(self._get_index_name(collection_name))self.client.indices.refresh(index=self._get_index_name(collection_name))Security
Breaking Changes
Additional Information
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.