Fix panic in update-markdown. Uses errors and return to signal failu…#990
Merged
jsuereth merged 8 commits intoopen-telemetry:mainfrom Nov 4, 2025
Merged
Fix panic in update-markdown. Uses errors and return to signal failu…#990jsuereth merged 8 commits intoopen-telemetry:mainfrom
jsuereth merged 8 commits intoopen-telemetry:mainfrom
Conversation
3 tasks
jerbly
reviewed
Oct 30, 2025
Contributor
|
@jsuereth - minor doc typo to fix... also wondering if we have test cases for these failure scenarios? |
Contributor
Author
We don't, didn't have time to add them today, but I believe I could tomorrow |
Contributor
Author
|
@jerbly Ok, I added a test now |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #990 +/- ##
=====================================
Coverage 78.3% 78.3%
=====================================
Files 77 77
Lines 6122 6122
=====================================
+ Hits 4795 4796 +1
+ Misses 1327 1326 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Contributor
Author
|
@jerbly Done, and build is fixed now |
jerbly
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…re now.
Fixes #960