Make optional the target and the registry sub-directory for the weaver registry generate command.#962
Merged
lquerel merged 5 commits intoopen-telemetry:mainfrom Oct 7, 2025
Merged
Conversation
lmolkova
approved these changes
Sep 30, 2025
jsuereth
approved these changes
Oct 7, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
=====================================
Coverage 77.9% 77.9%
=====================================
Files 76 76
Lines 6020 6020
=====================================
+ Hits 4693 4695 +2
+ Misses 1327 1325 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #689
This PR aims to simplify the user experience of Weaver. Initially, Weaver required following a strict structure for templates (i.e. /registry//). With this PR, the registry subdirectory and the target are now optional.
For example, if you have your templates and the
weaver.yamlfile in themy-templatesdirectory, the following command now allows you to generate the templates:In the same way, suppose your templates are in the
my-templates/registry/rustdirectory (legacy style), the following 2 commands are equivalent.