Fail when JQ filter fails#894
Merged
lquerel merged 7 commits intoopen-telemetry:mainfrom Aug 22, 2025
Merged
Conversation
lmolkova
commented
Aug 21, 2025
jsuereth
approved these changes
Aug 21, 2025
lmolkova
commented
Aug 21, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #894 +/- ##
=======================================
- Coverage 77.9% 77.9% -0.1%
=======================================
Files 76 76
Lines 5956 5967 +11
=======================================
+ Hits 4643 4650 +7
- Misses 1313 1317 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jerbly
reviewed
Aug 22, 2025
|
|
||
| Options: | ||
| --debug... Turn debugging information on | ||
| --debug... Turn debugging information on. Use twice (--debug --debug) for trace-level logs. |
Contributor
There was a problem hiding this comment.
Seems weird. Why not have --trace?
Member
Author
Contributor
There was a problem hiding this comment.
The intention was to be able to define the verbosity level. It’s common practice to have -v, -vv, -vvv, but I didn’t specify that I wanted the short -v and not -d. Sorry for this oversight. If you prefer to use --trace, I have no objection.
Contributor
|
Thanks for this fix. It will greatly improve the user experience! |
lquerel
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're only failing when filter is invalid, but ignore execution errors.
Fixed it, added test, and debug logs
Before: no output, no error, complete black hole
After: