Fix error messages for unversioned files. version: ... syntax will need fixed up later#880
Merged
lquerel merged 5 commits intoopen-telemetry:mainfrom Aug 15, 2025
Merged
Conversation
version: ... syntax will need fixed up later
jerbly
approved these changes
Aug 14, 2025
Contributor
jerbly
left a comment
There was a problem hiding this comment.
This makes sense to bring back the prior behaviour. Needs a changelog entry.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
=======================================
+ Coverage 77.7% 77.9% +0.2%
=======================================
Files 76 76
Lines 5936 5956 +20
=======================================
+ Hits 4616 4644 +28
+ Misses 1320 1312 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes unversioned file error messages, versioned files still get horrible results.
Example new (well old, but returned) error message:
However, once you add the version flag, you're back to bad error messages:
or even worse:
Will fix this up as part of V2 schema efforts.