Three registry dependency chain#856
Merged
jerbly merged 13 commits intoopen-telemetry:mainfrom Jul 30, 2025
Merged
Conversation
…try in garbage collection logic
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #856 +/- ##
=======================================
+ Coverage 76.6% 76.7% +0.1%
=======================================
Files 69 69
Lines 5587 5609 +22
=======================================
+ Hits 4282 4305 +23
+ Misses 1305 1304 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lmolkova
reviewed
Jul 28, 2025
lquerel
approved these changes
Jul 29, 2025
Contributor
lquerel
left a comment
There was a problem hiding this comment.
I just made a suggestion about the maximum depth for dependencies between registries, but otherwise it LGTM.
crates/weaver_resolver/data/multi-registry/app_registry/app_registry.yaml
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for a three registry dependency chain, a->b->c. This pattern is useful when making narrow application registries that depend on a corporate registry based on the OpenTelemetry semantic conventions. Max depth 10.