Include unit in inferred schema even if empty#1284
Merged
jsuereth merged 1 commit intoopen-telemetry:mainfrom Mar 13, 2026
Merged
Include unit in inferred schema even if empty#1284jsuereth merged 1 commit intoopen-telemetry:mainfrom
jsuereth merged 1 commit intoopen-telemetry:mainfrom
Conversation
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1284 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 111 111
Lines 9377 9377
=====================================
Hits 7624 7624
Misses 1753 1753 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsuereth
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After testing this end-to-end with
live-check, I've noticed a bug where I first infer a schema from an OTLP message that doesn't include units, and the generated schema would fail live-check because units are a required field.Manually adding the unit field to the generated schema fixed the problem, so I'm adding this fix to the
infercommand.