Add json schema for policy findings, make context optional#1270
Merged
jsuereth merged 4 commits intoopen-telemetry:mainfrom Mar 9, 2026
Merged
Add json schema for policy findings, make context optional#1270jsuereth merged 4 commits intoopen-telemetry:mainfrom
jsuereth merged 4 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1270 +/- ##
=====================================
Coverage 80.9% 81.0%
=====================================
Files 111 111
Lines 9377 9380 +3
=====================================
+ Hits 7592 7601 +9
+ Misses 1785 1779 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsuereth
approved these changes
Mar 9, 2026
| pub struct FindingBuilder { | ||
| id: String, | ||
| context: JsonValue, | ||
| context: Option<JsonValue>, |
Contributor
There was a problem hiding this comment.
Ah - I noticed this but forgot to make a note/issue to fix later. Thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noticed that context is required on PolicyFinding while working on open-telemetry/opentelemetry-weaver-packages#24, but it does not need to be, so fixing that and also adding json schema for it