Support imports for all signal types and public attribute groups.#1267
Merged
jsuereth merged 10 commits intoopen-telemetry:mainfrom Mar 9, 2026
Merged
Support imports for all signal types and public attribute groups.#1267jsuereth merged 10 commits intoopen-telemetry:mainfrom
jsuereth merged 10 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
=======================================
+ Coverage 80.8% 80.9% +0.1%
=======================================
Files 111 111
Lines 9308 9377 +69
=======================================
+ Hits 7523 7593 +70
+ Misses 1785 1784 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@lmolkova When I went to update the v1 schema, it was a massive change, does this look right to you or did I do something wrong? |
lmolkova
reviewed
Mar 6, 2026
lmolkova
reviewed
Mar 6, 2026
lmolkova
reviewed
Mar 6, 2026
lquerel
approved these changes
Mar 6, 2026
Contributor
lquerel
left a comment
There was a problem hiding this comment.
LGTM.
I noticed a potential regression in the semconv.schema.json.
lmolkova
approved these changes
Mar 9, 2026
| @@ -0,0 +1,32 @@ | |||
| version: '2' | |||
Member
There was a problem hiding this comment.
Suggested change
| version: '2' | |
| file_format: definition/2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand import support so we can cover all possible scenarios.