Initial cut at supporting refinements in v2 syntax.#1250
Initial cut at supporting refinements in v2 syntax.#1250jsuereth merged 23 commits intoopen-telemetry:mainfrom
Conversation
crates/weaver_resolver/data/registry-test-v2-4-refinements/registry/v2-refinements.yaml
Outdated
Show resolved
Hide resolved
crates/weaver_resolver/data/registry-test-v2-4-refinements/registry/v2-refinements.yaml
Outdated
Show resolved
Hide resolved
crates/weaver_resolver/data/registry-test-v2-4-refinements/registry/v2-refinements.yaml
Outdated
Show resolved
Hide resolved
| "name": "base.entity", | ||
| "lineage": { | ||
| "provenance": { | ||
| "registry_id": "default", |
There was a problem hiding this comment.
unrelated, I need to clean this one up
There was a problem hiding this comment.
Yeah - I need to sort out provenance going forward. I don't think we can declare resolved schema final until it's added, but I think we can add it in a non-breaking way.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1250 +/- ##
=======================================
+ Coverage 80.4% 80.8% +0.3%
=======================================
Files 110 111 +1
Lines 9025 9257 +232
=======================================
+ Hits 7260 7482 +222
- Misses 1765 1775 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…le special new capabilities in v2.
lmolkova
left a comment
There was a problem hiding this comment.
Looks great, just a few minor comments
|
|
||
| - `attributes`: Contains definitions of semantic attributes which may be applicable to all OpenTelemetry signals. | ||
| - `entities`: Contains definitions of entities. | ||
| - `entity_refinements`: Contains definitions of entity refinements. |
There was a problem hiding this comment.
there are also sections underneath to describe format in human-readable form, e.g. https://github.com/jsuereth/weaver/blob/6b909ea304d8d727a2a96a6b12dddb19b97e02de/schemas/semconv-syntax.v2.md#entities-definition
(cached and blessed AI output so that people don't need to AI that for us)
There was a problem hiding this comment.
oh, I fixed that, need to re-push
There was a problem hiding this comment.
huh, the commit is showing up in git locally, but not github - odd
lquerel
left a comment
There was a problem hiding this comment.
LGTM.
nit: I believe the json schema need to be updated now that you support some merging.
Note: I used gemini-cli to aide in the writing of this PR.
refinementto actually be a refinement. This means metric names, notes, etc. will be copied from the refined group vs. needing to be restated.is_v2flag to track v2 refinements through V1 so resolution engine will work.extendsadditionally having more things that can be pulled in.This does NOT do the following: