Fix 404 on template type attributes#1240
Merged
jerbly merged 1 commit intoopen-telemetry:mainfrom Feb 25, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1240 +/- ##
=====================================
Coverage 80.4% 80.4%
=====================================
Files 110 110
Lines 8984 8984
=====================================
Hits 7225 7225
Misses 1759 1759 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsuereth
approved these changes
Feb 25, 2026
| // O(1) lookup via SearchContext | ||
| match state.search_ctx.get_attribute(key) { | ||
| // O(1) lookup via SearchContext, checking both regular and template attributes | ||
| match state |
Contributor
There was a problem hiding this comment.
Would be nice if we had tests for the API in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug in the serve api. Attempts to get a template-type attribute would return a 404.