Live-check: correctly handle --no-stats in report mode.#1142
Merged
jsuereth merged 2 commits intoopen-telemetry:mainfrom Jan 20, 2026
Merged
Live-check: correctly handle --no-stats in report mode.#1142jsuereth merged 2 commits intoopen-telemetry:mainfrom
--no-stats in report mode.#1142jsuereth merged 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1142 +/- ##
=======================================
- Coverage 80.3% 80.2% -0.1%
=======================================
Files 106 106
Lines 8175 8175
=======================================
- Hits 6566 6563 -3
- Misses 1609 1612 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xrmx
approved these changes
Jan 20, 2026
Contributor
xrmx
left a comment
There was a problem hiding this comment.
Thanks, works for me. Can this be easily tested?
Contributor
Author
I'm reworking part of the test suite for #1132 - just wanted to get this PR out if we do a release before that new feature is ready. |
jsuereth
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1133 - this was not any kind of race hazard or anything specifically to do with json output. I had not correctly handled the combination of
--no-statswhen running in report mode (when the output is collected and reported at the end, typically to a file).