Support continuous live-check#1066
Merged
jerbly merged 7 commits intoopen-telemetry:mainfrom Dec 11, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
=====================================
Coverage 79.3% 79.4%
=====================================
Files 98 99 +1
Lines 7323 7346 +23
=====================================
+ Hits 5812 5835 +23
Misses 1511 1511 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsuereth
reviewed
Dec 10, 2025
Merged
lmolkova
reviewed
Dec 10, 2025
jsuereth
approved these changes
Dec 10, 2025
|
|
||
| impl LiveCheckStatistics { | ||
| /// Add a live check result to the stats | ||
| pub fn maybe_add_live_check_result(&mut self, live_check_result: Option<&LiveCheckResult>) { |
Contributor
There was a problem hiding this comment.
Nice! I like this division
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we can emit findings as log_records, we can support continuously running live-check. These changes aid this mode of operation:
--inactivity-timeout=0-> If this is set to zero then it never times out--output=none-> if this is set to none then no template engine is loaded and nothing is rendered out--no-stats-> if this is set then statistics are not accumulated over the running time of live-check which has the potential to otherwise store a lot of info in memory.We may want a convenience option to set all these up with one flag but I'm trying not to add more options. These individual tweaks have their own merit independently.