Skip to content

Implement weaver registry diff on V2 schema#1053

Merged
jsuereth merged 5 commits intoopen-telemetry:mainfrom
jsuereth:wip-v2-diff
Dec 6, 2025
Merged

Implement weaver registry diff on V2 schema#1053
jsuereth merged 5 commits intoopen-telemetry:mainfrom
jsuereth:wip-v2-diff

Conversation

@jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Dec 4, 2025

  • Only supports registry diffs (which is what previous did).
  • Limited tests for now.
  • Unblocks prototyping / working with V2.

@jsuereth jsuereth requested a review from a team as a code owner December 4, 2025 22:37
@jsuereth jsuereth mentioned this pull request Dec 4, 2025
Open
23 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 4, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Dec 4, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 55.33981% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.9%. Comparing base (1c6e526) to head (821ca43).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_resolved_schema/src/v2/mod.rs 59.4% 32 Missing ⚠️
...s/weaver_resolved_schema/src/v2/attribute_group.rs 0.0% 3 Missing ⚠️
crates/weaver_resolved_schema/src/v2/entity.rs 0.0% 3 Missing ⚠️
crates/weaver_resolved_schema/src/v2/event.rs 0.0% 3 Missing ⚠️
crates/weaver_resolved_schema/src/v2/span.rs 0.0% 3 Missing ⚠️
crates/weaver_resolved_schema/src/v2/metric.rs 33.3% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #1053     +/-   ##
=======================================
- Coverage   79.2%   78.9%   -0.4%     
=======================================
  Files         92      98      +6     
  Lines       7231    7334    +103     
=======================================
+ Hits        5734    5791     +57     
- Misses      1497    1543     +46

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsuereth jsuereth changed the title First cut at V2 weaver registry diff. Implement weaver registry diff on V2 schema Dec 5, 2025
jerbly
jerbly approved these changes Dec 6, 2025
View reviewed changes
Copy link
Contributor

@jerbly jerbly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lquerel
lquerel approved these changes Dec 6, 2025
View reviewed changes
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsuereth jsuereth merged commit 4782ee6 into open-telemetry:main Dec 6, 2025
22 of 23 checks passed
@jsuereth jsuereth deleted the wip-v2-diff branch December 6, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lquerel lquerel lquerel approved these changes

@jerbly jerbly jerbly approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsuereth @lquerel @jerbly