Skip to content

Emit and live-check event support#1042

Merged
jsuereth merged 11 commits intoopen-telemetry:mainfrom
jerbly:log-support
Dec 2, 2025
Merged

Emit and live-check event support#1042
jsuereth merged 11 commits intoopen-telemetry:mainfrom
jerbly:log-support

Conversation

@jerbly
Copy link
Contributor

@jerbly jerbly commented Nov 28, 2025 •
edited
Loading

Resolves #1017 and #1018

  • Emit will now send events as defined in the model
  • Live-check now provides advice for events
image

@jerbly jerbly requested a review from a team as a code owner November 28, 2025 03:19
@jerbly jerbly marked this pull request as draft November 28, 2025 03:37
@codecov
Copy link

codecov bot commented Nov 28, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.55556% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.9%. Comparing base (47bba7a) to head (32dfba0).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_emit/src/lib.rs 51.8% 13 Missing ⚠️
crates/weaver_live_check/src/advice.rs 92.0% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #1042     +/-   ##
=======================================
+ Coverage   78.7%   78.9%   +0.2%     
=======================================
  Files         82      84      +2     
  Lines       6770    6945    +175     
=======================================
+ Hits        5328    5486    +158     
- Misses      1442    1459     +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jerbly jerbly marked this pull request as ready for review November 28, 2025 17:22
@jerbly jerbly changed the title [WIP] Emit and live-check event support Emit and live-check event support Nov 28, 2025
lmolkova
lmolkova reviewed Nov 28, 2025
View reviewed changes
@jerbly jerbly requested a review from lmolkova November 29, 2025 03:38
jsuereth
jsuereth approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM. I think @lmolkova raises a good point about Event vs. Log we need to discuss more of, but I believe this PR could be submitted and we can expand support for non-event-name going forward.

lmolkova
lmolkova approved these changes Dec 1, 2025
View reviewed changes
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rename event to log in signal_type and other public-facing places to align with the spec language and be future proof

crates/weaver_live_check/src/advice.rs Outdated
deprecated
),
level: FindingLevel::Violation,
signal_type: Some("event".to_owned()),
Copy link
Member

@lmolkova lmolkova Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use log as a signal (that's the spec terminology). Events are subtype of logs

Copy link
Contributor Author

@jerbly jerbly Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed everything to Log. In the standard output I've made a small distinction between Log and Log Event see the screenshot.
image

@jsuereth jsuereth merged commit bdd1dd5 into open-telemetry:main Dec 2, 2025
24 checks passed
@jerbly jerbly mentioned this pull request Dec 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsuereth jsuereth jsuereth approved these changes

@lmolkova lmolkova lmolkova approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support logs & events in live-check

3 participants

@jerbly @jsuereth @lmolkova