Skip to content

Update code so weaver check now supports v2 schema.#1016

Merged
jsuereth merged 22 commits intoopen-telemetry:mainfrom
jsuereth:wip-v2-weaver-check
Nov 24, 2025
Merged

Update code so weaver check now supports v2 schema.#1016
jsuereth merged 22 commits intoopen-telemetry:mainfrom
jsuereth:wip-v2-weaver-check

Conversation

@jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Nov 19, 2025 •
edited
Loading

  • Adds a new flag which will force all policies to use new v2 schema
  • Tests after_resolution policy against v2 schema
  • Tests comparison with baseline policy with v2 schema
  • Adds warning to before_resolution for v2 schema and policies. (We will not support before_resolution in v2, for now)

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 19, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Nov 19, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.6%. Comparing base (2cdae95) to head (c71929f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_resolved_schema/src/v2/mod.rs 64.2% 5 Missing ⚠️
crates/weaver_resolved_schema/src/error.rs 0.0% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #1016     +/-   ##
=======================================
- Coverage   78.7%   78.6%   -0.1%     
=======================================
  Files         82      82             
  Lines       6606    6612      +6     
=======================================
+ Hits        5200    5202      +2     
- Misses      1406    1410      +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 19, 2025
View reviewed changes
@jsuereth jsuereth mentioned this pull request Nov 19, 2025
Open
23 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 20, 2025
View reviewed changes
@jsuereth jsuereth marked this pull request as ready for review November 20, 2025 20:58
@jsuereth jsuereth requested a review from a team as a code owner November 20, 2025 20:58
@lmolkova lmolkova mentioned this pull request Nov 21, 2025
Merged
lmolkova
lmolkova approved these changes Nov 21, 2025
View reviewed changes
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out in semconv, works like a charm!

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2025
View reviewed changes
jerbly
jerbly approved these changes Nov 24, 2025
View reviewed changes
Copy link
Contributor

@jerbly jerbly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsuereth jsuereth enabled auto-merge (squash) November 24, 2025 12:20
@jsuereth jsuereth merged commit 1511626 into open-telemetry:main Nov 24, 2025
20 checks passed
@jsuereth jsuereth deleted the wip-v2-weaver-check branch January 26, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerbly jerbly jerbly approved these changes

@lmolkova lmolkova lmolkova approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsuereth @jerbly @lmolkova