Skip to content

Make url.scheme opt in for HTTP client metrics and make server.port required#459

Merged
AlexanderWert merged 5 commits into
open-telemetry:mainfrom
lmolkova:http-server-port-scheme
Oct 31, 2023
Merged

Make url.scheme opt in for HTTP client metrics and make server.port required#459
AlexanderWert merged 5 commits into
open-telemetry:mainfrom
lmolkova:http-server-port-scheme

Conversation

@lmolkova

@lmolkova lmolkova commented Oct 27, 2023

Copy link
Copy Markdown
Member

Fixes #450

Changes

Merge requirement checklist

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmolkova and I checked, and server.port is the last HTTP semconv attribute that has (had) a default value

Comment thread docs/http/http-spans.md
@lmolkova lmolkova marked this pull request as ready for review October 27, 2023 23:22
@lmolkova lmolkova requested review from a team October 27, 2023 23:22
@lmolkova lmolkova force-pushed the http-server-port-scheme branch from 1cf7d74 to a927078 Compare October 30, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

url.scheme is present on HTTP client metrics but not HTTP client spans

6 participants