Fix server.port to be not required on HTTP server spans when server.address is not set#429
Merged
arminru merged 2 commits intoOct 23, 2023
Conversation
18caf7a to
7df62e7
Compare
3 tasks
lmolkova
approved these changes
Oct 19, 2023
mateuszrzeszutek
approved these changes
Oct 20, 2023
pyohannes
approved these changes
Oct 20, 2023
joaopgrassi
approved these changes
Oct 23, 2023
arminru
approved these changes
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #424
Changes
Fixes
server.portto be not required on HTTP server spans whenserver.addressis not set (server.addressis only recommend on HTTP server spans, not required, see #111).Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.