Make server.port conditionally required on HTTP server semconv#399
Merged
AlexanderWert merged 4 commits intoOct 16, 2023
Merged
Conversation
cd7259d to
ac3086a
Compare
lmolkova
approved these changes
Oct 12, 2023
mateuszrzeszutek
approved these changes
Oct 13, 2023
Oberon00
approved these changes
Oct 13, 2023
pyohannes
approved these changes
Oct 13, 2023
joaopgrassi
reviewed
Oct 13, 2023
joaopgrassi
approved these changes
Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #385
Changes
Makes
server.portconditionally required on HTTP server semconv when it is not the default for the givenurl.scheme(80/443).This avoids the question of whether missing
server.portmeans default or unknown.And we expect
server.portto be available to all HTTP server instrumentation.Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.